mkhorasani / Streamlit-Authenticator

A secure authentication module to manage user access in a Streamlit application.
Other
1.56k stars 248 forks source link

Allow Domain Access + Full Widget #44

Closed abdulrabbani00 closed 8 months ago

abdulrabbani00 commented 1 year ago

This PR does a few things:

Issues: https://github.com/mkhorasani/Streamlit-Authenticator/issues/43, https://github.com/mkhorasani/Streamlit-Authenticator/issues/42

abdulrabbani00 commented 1 year ago

@mkhorasani - Any thoughts here? Would love to get this merged.

VovaViliLox commented 1 year ago

@mkhorasani Hello! Any updates on this PR? I would absolutely love to use it in my Streamlit project.

mkhorasani commented 1 year ago

Apologies for the delay @abdulrabbani00 and @VovaViliLox will attend to this very soon!

abdulrabbani00 commented 1 year ago

@mkhorasani - I have made the requested changes, I hope they are satisfactory. I included a few pictures and made the code additions clearer. I hope this can be merged quickly.

abdulrabbani00 commented 1 year ago

@mkhorasani - Just wanted to follow up on this.

Civel-1 commented 11 months ago

Any news about that features ? :) Would be lovely to have it !

ProHaller commented 8 months ago

Any news on this merge? I'm looking forward to having it accepted! Thank you for the work.

mkhorasani commented 8 months ago

Dear all, please note that a major refactoring of this package is in progress which should address some of the issues raised in this PR and others in one update. At the moment I am able to merge the following features only:

Dear @abdulrabbani00 please feel free to modify your PR accordingly. Thank you!

abdulrabbani00 commented 8 months ago

I appreciate all the interest from everyone. But I do not have the capacity to continue on this PR. I've made modifications and corrections in the past and they did not get reviewed and merged. Feel free to create a branch and make any modifications if you need any of these features. You can also use this fork in your local codebase if you need these features.

Best of luck everyone.