Add configurable validation for username, name, and email

mkhorasani / Streamlit-Authenticator

A secure authentication module to validate user credentials in a Streamlit application.

Apache License 2.0

1.38k stars 229 forks source link

Add configurable validation for username, name, and email #63

Closed velicanu closed 1 year ago

velicanu commented 1 year ago

Hey @mkhorasani ,

This PR is an alternative implementation to https://github.com/mkhorasani/Streamlit-Authenticator/pull/52 in order to address https://github.com/mkhorasani/Streamlit-Authenticator/issues/53 .

The reasons I propose this implementation (over https://github.com/mkhorasani/Streamlit-Authenticator/pull/52) are the following:

allows users to specify their own validators if their requirements differ from the defaults here
loosen default name validation, since names around the world can have all sorts of characters
loosen email validation, emails are also hard to validate properly, the best strategy is to actually try to email the provided address and wait for a response
simpler code change to the existing logic

I tested this out in one of my projects using this library and it seems to work.

velicanu commented 1 year ago

Thank you for the changes. Please review the changes/comments and submit them again! Cheers.

Done: https://github.com/mkhorasani/Streamlit-Authenticator/pull/63/commits/25fc3c552331d617d87c2c80a113e695eb2f5ef7

By the way did you mean to delete the whole setup file or just revert my change in this commit? https://github.com/mkhorasani/Streamlit-Authenticator/pull/63/commits/3ef4a2cf533a8270c0fc365ac4e1562dee8ca791

mkhorasani commented 1 year ago

Thank you for the changes. Please review the changes/comments and submit them again! Cheers.

Done: 25fc3c5

By the way did you mean to delete the whole setup file or just revert my change in this commit? 3ef4a2c

That was fast! No, I only meant to revert the changes.

mkhorasani commented 1 year ago

Thank you. Pull request merged!

mkhorasani commented 1 year ago

Hi @velicanu, can you please provide a description for the validator object that is used in the constructor of the Authenticate class on this line? You can just add the comment as a reply to this message and I can then push it to the repo. Thanks.

velicanu commented 1 year ago

Sure @mkhorasani !

        validator: Validator
            A Validator object that checks the validity of the username, name, and email fields

mkhorasani commented 1 year ago

Sure @mkhorasani !

        validator: Validator
            A Validator object that checks the validity of the username, name, and email fields

Cheers!