Update Format-Json.ps1 - Githubissues

mkht / pspm

PowerShell Package Manager

MIT License

13 stars 1 forks source link

Update Format-Json.ps1 #73

Closed vody closed 4 years ago

vody commented 4 years ago

Update regex expressions solving an issue when [,{,},] characters exists in a value

mkht commented 4 years ago

Hi @vody Thank you for your contribution! Please give me a moment so I will review about your code. :-)

mkht commented 4 years ago

@vody. I made an Issue #74 about the problem that this PR will solve. Can you confirm that I am not mistaken in my understanding?

vody commented 4 years ago

Hi @mkht Actually I was referring to a json with { [ ] } characters in it's value. Like this one: { "key1": "val{0}e1", "key2": "value2" } With original version, "key2" line will be indented incorrectly. But I am happy that it is solving other issue as well 👍

mkht commented 4 years ago

Hi @vody Thank you for the explanation. Your code looks great, so I will merge it immediately.

After I do the merge, I'm going to make some additional edits to the code to resolve it, including the issue I presented in #74. 😄