When decoding Time with empty string, toggle IsSet - Githubissues

mkideal / cli

CLI - A package for building command line app with go

MIT License

732 stars 43 forks source link

When decoding Time with empty string, toggle IsSet #55

Closed rtgibbons closed 3 years ago

rtgibbons commented 5 years ago

https://github.com/mkideal/cli/blob/205c0b83093311fee1b048df54ae7d7b77dd0ef2/ext/decoders.go#L51-L55

I think it makes sense to toggle IsSet to true here?

suntong commented 3 years ago

close via https://github.com/mkideal/cli/commit/238c6b9d5b144e972cef28b7129ca7eebdecbf03