search

mking / react-hn

Learn React by building the Hacker News front page
424 stars 64 forks source link

Made navLinks in NewsHeader static and updated README to reflect this #4

Closed jrotolo closed 9 years ago

jrotolo commented 9 years ago

Since navLinks is data that isn't changing it would make more sense to put it as static. This way we aren't re-rending this data on updates.

mking commented 9 years ago

This looks great and if this were production code I would definitely support this. However, one issue I've seen with tutorials is introducing too many concepts at one time. While I think statics are a very easy concept to understand, I want to put a hard limit on the number of concepts introduced so that the reader isn't overwhelmed.