mkiol / GNotifier

Thunderbird add-on that replaces built-in notifications with the OS native notifications
https://addons.mozilla.org/thunderbird/addon/gnotifier/
GNU General Public License v3.0
164 stars 25 forks source link

[Thunderbird] Click action do not work on Windows 10 #103

Open dbalabka opened 8 years ago

dbalabka commented 8 years ago

For some reason when click on Notification notfing happen. I will be great to implement possibility to show exact message after click on Notification.

mkiol commented 8 years ago

Click action for Thunderbird was added in #99. It should be supported in the latest 1.9.7-pre1 XPI, but unfortunately this package is not signed yet.

dbalabka commented 8 years ago

@mkiol I have checked 1.9.7-pre1 version. On click action works. But I have proposal. Is it possible to open message not in new tab, but in defaul view: image

tooomm commented 8 years ago

Or make it selectable like for file downloads...

Jump to new message / Show message in new tab I don't like to read messages in tabs at all, I just open a few very important messages in tabs to keep track of them while working on other things.

mkiol commented 8 years ago

Or make it selectable

OK, will be in upcoming release.

tooomm commented 8 years ago

One more thing... testing with 1.9.7-pre1 If I get a new mail notification and click it, it should open Thunderbird and open the just received mail in a new tab.

But if Thunderbird is not in focus (minimized or in the background) it stays there and comes not to the front! The mail is correctly opened in the tab nevertheless. It doesn't work when viewing local pictures for example - it does work however when browsing the internet with Firefox!

mkiol commented 8 years ago

But if Thunderbird is not in focus (minimized or in the background) it stays there and comes not to the front!

Thanks for noticing it. You are right, it works on Windows just like you described. Adding it to my TO-DO list for the next release.

mkiol commented 8 years ago

@torinaki @tooomm

Please check the latest XPI. There is new option "Open new message action" that defines whether to open message in the new tab or just to select message on the list.

Bringing TB window to the front should work as well.

tooomm commented 8 years ago

Both work smoothly for me! Well done! :+1:

bertvn commented 8 years ago

If thunderbird is minimized it stays minimized instead of coming into focus

tooomm commented 8 years ago

Which version do you run @bertvn? I guess you are still on old 1.9.6 final or something? What's your OS?

bertvn commented 8 years ago

1.9.7 according to thunderbird. it does work if it is behind other windows but not when it's minimized

I'm using windows 10

tooomm commented 8 years ago

You are totally right. Same for me. I used to not realize it because I also run the "Fire Tray" addon which minimized Thunderbird to the tray... it works with no issues in that constellation. I was sure I also tested with it disabled, well.

Once I disable it now it gives me the exact same problem than you have.