search

mkiol / GNotifier

Thunderbird add-on that replaces built-in notifications with the OS native notifications
https://addons.mozilla.org/thunderbird/addon/gnotifier/
GNU General Public License v3.0
164 stars 25 forks source link

[FF+TB] click action on download finished message doesn't focus file on windows #109

Closed tooomm closed 7 years ago

tooomm commented 8 years ago

The click action should not just open the folder containing the downloaded file, but also pre-select/highlight the new file and scroll to show it... Especially in download folders it's generally a mess to find stuff.

For example: Go to the download history in Firefox (click the arrow icon for downloads in the upper right), right click on a recently downloaded file and choose Open Containing Folder. Firefox will open the containing folder and select the file. That's so useful! The standard Thunderbird notification, if you download an attachment for example, doesn't offer this as well.

tooomm commented 7 years ago

FYI: Even after your "fix" in 86571b0 I experience the same behavior with Thunderbird 45.3.0 on Win 10 and your gnotifier-1.9.8-pre2.xpi from here.

I can switch in options between "Open File" and "Open Folder" for Default click action. Both do what they should, but "Open Folder" still doesn't focus/highlight the actual file. It just opens the containing folder.

mkiol commented 7 years ago

My mistake, I didn't realize I didn't upload the latest XPI version. Please, try the gnotifier-1.9.8-pre3.xpi.

tooomm commented 7 years ago

Working now. Awesome! :heart:

mkiol commented 7 years ago

Glad I could help :-)

mkiol commented 7 years ago

Fixed in the latest AMO release - 1.9.8.