mkiol / GNotifier

Thunderbird add-on that replaces built-in notifications with the OS native notifications
https://addons.mozilla.org/thunderbird/addon/gnotifier/
GNU General Public License v3.0
164 stars 25 forks source link

Does not replace firefox notifications created by Gmail Notifier (Restartless) #121

Closed AndydeCleyre closed 7 years ago

AndydeCleyre commented 8 years ago

Hi,

Using

Firefox notifications are used, regardless of whether the Notification Engine is set to GNotifier or Standard.

mkiol commented 8 years ago

Thanks for the report.

Could you please try to do following:

AndydeCleyre commented 8 years ago

Thanks. I've done that, but the output hasn't changed, it's just a few GTK warnings:

(firefox:6975): Gtk-WARNING **: Theme parsing error: gtk.css:2249:17: negative values are not allowed.
(firefox:6975): Gtk-WARNING **: Theme parsing error: gtk.css:3973:20: negative values are not allowed.
(firefox:6975): Gtk-WARNING **: Theme directory actions/48 of theme breeze has no size field
(firefox:6975): Gtk-WARNING **: Theme directory categories/16 of theme breeze has no size field
(firefox:6975): Gtk-WARNING **: Theme directory categories/22 of theme breeze has no size field
(firefox:6975): Gtk-WARNING **: Theme directory categories/48 of theme breeze has no size field
(firefox:6975): Gtk-WARNING **: Theme directory devices/48 of theme breeze has no size field
(firefox:6975): Gtk-WARNING **: Theme directory base/ of theme oxygen has no size field
AndydeCleyre commented 8 years ago

On the computer experiencing this, I'm using an infinality font configuration. It just occurred to me that this might be related.

mkiol commented 8 years ago

Hmm.. I wil try to setup environment similar to yours but, honestly, hardly believe that font configuration is a source of the issue.

AndydeCleyre commented 7 years ago

I just set up a new FF profile, added some extensions (including this one), and am still having the issue.

I noticed the custom command option, though. So I set the engine to custom, and made the custom command:

notify-send -i "%image" "%title" "%text"

But this still uses the FF notifications, and sometimes they're even partially off the screen.

So I added that logging level option you mentioned, and here's the output on launch (a notification for email is shown on launch) with the obviously other-extension and non-error stuff filtered out:

(firefox:3995): Gtk-WARNING **: Theme directory base/ of theme oxygen has no size field

console.warn: SDK worker-child started as frozen on unexpected initial document.readyState {"initialDocumentReadyState":"uninitialized","windowLocation":"about:config"}
console.warn: SDK worker-child started as frozen on unexpected initial document.readyState {"initialDocumentReadyState":"uninitialized","windowLocation":"about:blank"}
console.warn: SDK worker-child started as frozen on unexpected initial document.readyState {"initialDocumentReadyState":"uninitialized","windowLocation":"about:blank"}
AndydeCleyre commented 7 years ago

And it's the same behavior with the simpler custom command:

notify-send "%title" "%text"
mkiol commented 7 years ago

I made tests in the following environment and everything seems to be working fine, including "Custom command" and notify-send -i "%image" "%title" "%text"...

Did you try to test it with the fresh FF profile, without any other add-ons?

AndydeCleyre commented 7 years ago

I just created a brand new profile, installed gnotifier, and it worked.

So I went through and added my usual extensions, testing again after each one. It worked.

I went back to my current real-use profile and tested the same way . . . and it worked!

I'm sorry for the noise -- most (if not all) of my firefox notifications come from the Gmail Notifier (Restartless) addon, and I am now realizing it does not use the firefox notification system; I guess it uses its own. I thought I had remembered your extension working with that one, but I was probably mistaken.

Until today all my notification testing was done by clicking the refresh button on that gmail addon.

Thanks for looking at this with me, and sorry again for my ignorant false-testing.

AndydeCleyre commented 7 years ago

Hmm, it looks like that extension does use FF's notifications.

I'm re-opening, and editing the title to focus on compatibility with that extension.

AndydeCleyre commented 7 years ago

Aaaand today, this works.

firefox 49.0 ignotifier 0.6.5 gnotifier 1.9.7

mkiol commented 7 years ago

It is "well known" problem that was already discussed in #33. If some add-on is loaded (during FF start) before Gnotifier, notifications will not work. The order in which they are loaded is somehow indeterministic, so from time to time everything works well. The only solution I found is to do very small change in add-on that should interwork with GNotifier.

Let me get back to you later after I review ignotifier source code.