mkiol / GNotifier

Thunderbird add-on that replaces built-in notifications with the OS native notifications
https://addons.mozilla.org/thunderbird/addon/gnotifier/
GNU General Public License v3.0
164 stars 25 forks source link

Exclude certain folders from notification #125

Closed ndeubert closed 8 years ago

ndeubert commented 8 years ago

I am wondering if there is a way to tell it to not notify for certain folders. I looked through some of the code and saw this and was wondering how to set a folder as excluded?

source/lib/thunderbird.js: 243 function isFolderExcluded(folder) {

Thanks, Nick

mkiol commented 8 years ago

There is no UI for that, but definitely you can do it by altering the code inside isFolderExcluded. Notification is not shown if function returns true. Folder API is depicted here. For instance, name of the folder is folder.name or folder.rootFolder.name...

pd5rm commented 8 years ago

I just found out about GNotifer (and really like it so far), but I have the same feature request. A way to either include or exclude folders for notifications. In my case, I only care about receiving updates for Inbox.

I saw the code for isFolderExcluded (/source/lib/thunderbird.js), it would be nice to be able to choose from list of folders in a UI. If I modify the code, I'd have to maintain it for newer releases.

Thanks again!

pd5rm commented 8 years ago

Well I tried to extend the package to allow for explicitly listing "included" folders, but failed. ;-(

127

mkiol commented 8 years ago

@pd5rm Thanks for your contribution. Your commits are included in the latest release.

pd5rm commented 8 years ago

Thanks! It was a pleasure contributing to your project. ;-)

Nick-Deubert-Bose commented 8 years ago

Great! Thanks to both of you.