search

mkiol / GNotifier

Thunderbird add-on that replaces built-in notifications with the OS native notifications
https://addons.mozilla.org/thunderbird/addon/gnotifier/
GNU General Public License v3.0
165 stars 25 forks source link

Thunderbird notifications for spam messages #166

Closed noahheck closed 6 years ago

noahheck commented 7 years ago

Recently (within the last week), I've started receiving notifications from Thunderbird when receiving messages that are marked as spam. This is different from the behavior from before where notifications were not shown for spam messages. When looking for the cause of the issue, I see that my GNotifier was updated on May 3, which coincides with the timeline of my issue.

I'm using Thunderbird 45.8.0 on Linux Mint 18.1.

mkiol commented 7 years ago

Thank you for reporting this. In the latest update I changed code responsible for new messages detection and probably mess something up. I will troubleshoot this.

noahheck commented 7 years ago

Great! Please let me know if I can help in some way :)

lightonflux commented 7 years ago

Does it look like this? bildschirmfoto von 2017-05-08 23-43-02

I am not sure what this is. If these notifications are mails that are marked as junk and moved to spam or if these are just broken notifications.

If it doesn't look like this for you then i open a new issue.

noahheck commented 7 years ago

Looks to be the same. spam_message

mkiol commented 7 years ago

I can confirm this bug. I'm working on the fix.

mkiol commented 7 years ago

Please try the latest (1.10.3) XPI. The issue with "empty" notifications should be resolved. I would be very grateful for testing it and feedback. Thanks!

noahheck commented 7 years ago

I have disabled all other addons, and installed the latest xpi (1.10.3) and am still receiving the notifications for spam messages.

mkiol commented 7 years ago

Thank you. My "problem" is that I hardly ever receive spam messages and it makes me hard to do proper tests.

Please try 1.10.4.

noahheck commented 7 years ago

Ha! First world problems. I'll trade you ;)

When I got in this morning, I discovered that Thunderbird on Linux Mint has been updated to 52.1.1 if that will affect testing.

I installed the 1.10.4 xpi and it seems to be functioning as expected now (i.e. not getting notifications for spam messages but still getting messages for valid ones).

Thank you so much! Let me know if there's anything else I can do.

mkiol commented 6 years ago

Issue resolved in 1.10.5 release.