search

mkiol / GNotifier

Thunderbird add-on that replaces built-in notifications with the OS native notifications
https://addons.mozilla.org/thunderbird/addon/gnotifier/
GNU General Public License v3.0
164 stars 25 forks source link

Icons are only shown for downloads #18

Closed dkadioglu closed 10 years ago

dkadioglu commented 10 years ago

Hi,

I experimented a bit more with GNotifier and I appreciate the functionality more and more. A remaining problem is that the notifications show up without icons except it is a notification for a finished download. I don't have any errors in the error console so I don't have any clue where to look for the culprit. Any idea?

Best regards

mkiol commented 10 years ago

Definitely it is the bug! I did small change and it seems that icons are now displayed correctly. Try to test version 1.7.3 on AMO -> https://addons.mozilla.org/en-US/firefox/addon/gnotifier/versions/?page=1#version-1.7.3

dkadioglu commented 10 years ago

It works now! Thank you.

One question: For each notification a file .gnotifierX.tmp is created with X being a incrementing number. But those files remain in /tmp under linux, even after Firefox has been closed. Is it possible to delete them after showing the notification?

mkiol commented 10 years ago

Yes.. you right. One more try ;-) Check this one: https://github.com/mkiol/GNotifier/raw/master/gnotifier.xpi

dkadioglu commented 10 years ago

The files are still not deleted. Anything I can do to debug this?

mkiol commented 10 years ago

Thanks for your effort. I made a stupid coding mistake. Temp files are created in /tmp/gnotifier-[random string] and they should be deleted in 1000ms after notification appeared. Try to test version 1.7.5: https://github.com/mkiol/GNotifier/raw/master/gnotifier.xpi

mkiol commented 10 years ago

I tested it using http://mkiol.net/gnotifier_test.html and it seems to work correctly.

dkadioglu commented 10 years ago

You're right, now it works as it should! Thank you!