mkiol / GNotifier

Thunderbird add-on that replaces built-in notifications with the OS native notifications
https://addons.mozilla.org/thunderbird/addon/gnotifier/
GNU General Public License v3.0
164 stars 25 forks source link

[not real issue but…] Signed or verified plugins ? #68

Closed Coeur-Noir closed 8 years ago

Coeur-Noir commented 8 years ago

Firefox warns about Gnotifier not being signed or verified

https://support.mozilla.org/en-US/kb/add-on-signing-in-firefox

Might be a problem later…

mkiol commented 8 years ago

Right... Signed version is the version reviewed by Mozilla. Currently 1.8.9 is signed and available to download on AMO. New version (1.9.0) is waiting (for few months) in the review quee. So, hopefully it will be signed sooner or later.

Coeur-Noir commented 8 years ago

capture du 2015-10-16 13 05 15 Thanx for your answer. So is the warning shown above "normal" ? Roughly it says : Gnotifier has not been verified for its use in Firefox. capture du 2015-10-16 13 09 28

mkiol commented 8 years ago

Something is wrong. Version "1.8.9.1-signed" is verified and signed. FF should not display warning message. Try to uninstall current version and install Gnotifier directly from https://addons.mozilla.org/pl/firefox/addon/gnotifier/.

Coeur-Noir commented 8 years ago

Hello,

Uninstall & re-install → you're right, no more warning !

Thanx a lot !

Le 16/10/2015 16:41, Mkiol a écrit :

Something is wrong. Version "1.8.9.1-signed" is verified and signed. FF should not display warning message. Try to uninstall current version and install Gnotifier directly from https://addons.mozilla.org/pl/firefox/addon/gnotifier/.

— Reply to this email directly or view it on GitHub https://github.com/mkiol/GNotifier/issues/68#issuecomment-148735418.

neopostmodern commented 8 years ago

Now, as of FF43, many users will run into this problem because unsigned extensions are now disabled by default and the upgrade path for this addon seams to somehow not automatically switch to the signed version. Is there anything that could be done to fix this before everybody (or: many users) has to uninstall & install manually?

EDIT - I uninstalled & reinstalled just now and issue persists; not signed. If I go here: https://addons.mozilla.org/en-US/firefox/addon/gnotifier/ the version is 1.9.1, not signed.

mkiol commented 8 years ago

by default and the upgrade path for this addon seams to somehow not automatically switch to the signed version

Honestly, I've no idea why auto-upgrade thing doesn't work. I don't see anything I could do to resolve this. The only solution I found so far is reinstalling.

I uninstalled & reinstalled just now and issue persists; not signed

I can't reproduced your observation. I've tested it on both fresh and not-fresh Windows and Linux installation and 1.9.1 package downloaded from AMO was always signed. I wonder if there is something specific in your setup which results in the problem?

neopostmodern commented 8 years ago

I just took a screenshot of the AMO site: gnotifier ...and versions history: gnotifier-versions

So: it seems that the 1.9.1 package offered to me for some reason is not signed.

This is FF43 on Ubuntu 15.10

mkiol commented 8 years ago

I think there has been some misunderstanding. So, "1.9.1" or "1.9.1-signed" is just a name and the lack of "-signed" doesn't indicate that package is not signed. When Mozilla introduced certificates for extension, all old XPI packages on AMO were auto signed and auto uploaded with new name ending with "-signed". But, now, every new XPI that pass AMO review process is signed by default, so there is no need to add anything to the name.

If your FF doesn't show warning message like below, everything is ok. capture du 2015-10-16 13 05 15

neopostmodern commented 8 years ago

Thanks for the clarification. The thing is, it does show the warning: gnotifier-about

mkiol commented 8 years ago

I'm puzzled.. have no idea where could be a problem. Did you try test it with a fresh FF profile?

neopostmodern commented 8 years ago

Just did. Works perfectly fine then. Which leaves me puzzled too, guess my current profile's just cursed. Thanks anyway. If anybody stumbles across this who knows how to delete the cached verifications...

ntninja commented 8 years ago

@neopostmodern Probably won't happen (did you try to delete/restart/install btw?) You could also try to remove (MAKING A BACKUP) the extensions.ini, extensions.json and extensions.sqlite files from your profile directory (~/.mozilla/firefox/<PROFILE NAME>).

neopostmodern commented 8 years ago

@alexander255 - Looks like it worked! Thank you! For anybody else, attempting above fix: you'll have to re-enable / re-install all your addons, but you'll be asked or just go to about:addons - it remembers you're collection.