[WEBXR] added option to pass WebXR Session options

mkkellogg / GaussianSplats3D

Three.js-based implementation of 3D Gaussian splatting

MIT License

1.54k stars 199 forks source link

[WEBXR] added option to pass WebXR Session options #283

Closed arthurlebourg closed 3 months ago

arthurlebourg commented 4 months ago

WebXR can accept some options for hit testing, depth sensing etc. In order to use those, we need to initialize those options by passing arguments to the navigator.xr.requestSession() method which is called within the {AR/VR}Button.createButton().

Is was not possible to pass the options to the builder so I fixed that.

Yours truly, Arthur Le Bourg

arthurlebourg commented 3 months ago

@mkkellogg this is a small tweak and will not break anything while allowing anyone to use webxr at its full extent.

mkkellogg commented 3 months ago

Sorry for the late response, I will definitely try to get this into the next release :)

mkkellogg commented 3 months ago

I included this fix with this PR that's going into dev soon and should be released this week.