mkkellogg / GaussianSplats3D

Three.js-based implementation of 3D Gaussian splatting
MIT License
1.53k stars 198 forks source link

Proposal to PMNDRS to replace their current Drei Splat wrapper with the mkkellogg dropinviewer #330

Open newguy123-creator opened 2 months ago

newguy123-creator commented 2 months ago

Hi Mr Kellogg

PMNDRS has a bunch of cool helpers for React Three Fiber in their Drei library, among other things they have a Drei Splat, which currently is a wrapper for antimatter15's viewer, and it works great and very simple to set things up in R3F. The issue is antimatter15's viewer hasnt been updated in a very long time and your viewer seems to perform better in my testing, has more features, and works in VR.

Do you have any objections if I ask them to see if they are open to the idea of switching their wrapper from antimatter15 to yours instead?

mkkellogg commented 2 months ago

You're certainly welcome to ask them, but I think they will prefer to keep the current implementation for couple of reasons. The first is the simplicity of the implementation; mine is more complex and more difficult to debug or modify. The second reason is that they've had the chance over the past 9 months (or however long it has been since it was added) to do testing of their current implementation and if they switch now, it will undo all that testing.

Additionally, one of the core authors of Drei and R3F (drcmda) originally enlisted my help for authoring the Splat component, but for whatever reason he preferred the antimatter implementation over my approach: https://discourse.threejs.org/t/3d-gaussian-splatting-in-three-js/57858/15