search

mkko / DrawerView

A drop-in view, to be used as a drawer anywhere in your app
MIT License
373 stars 57 forks source link

Collection behaves buggy when I am adding as a subview #20

Closed developweb10 closed 4 years ago

developweb10 commented 4 years ago

Hi, First of all, thank you for providing us a great tool, here is the issue I am facing when I am adding a Horizontal collection view as a subview of a drawer view When I am trying to scroll the collection view drawer gets changed its states.

kuchmiyalex commented 4 years ago

Hi, getting same issue, it's getting very hard to perform horizontal swipes

cjwillis809 commented 4 years ago

@mkko My team is seeing this same issue as well. We added a collection view as a subview to the drawer and it's very hard to scroll without triggering the drawer's gesture recognizer it seems. Have you gotten a chance to look at this?

mkko commented 4 years ago

Sorry, I haven't had the time yet. Do you have a working example of the issue? Would save a lot of time.

mkko commented 4 years ago

@developweb10 / @kuchmiyalex / @cjwillis809, I pushed version 1.3.1 with a minor fix to issue where at the end of a pan the horizontal lock was not regarded due to vertical velocity. In other words, sometimes the drawer got collapsed when there was enough vertical movement (despite the directional lock).

Does this address your issue? I still haven't had the time to try the drawer with collection view, so if the problem persists, I could look at some of your sample to determine the issue better.

developweb10 commented 4 years ago

@mkko , Yes it is working correctly when I update the pod 1.3.1... Thanks for providing me a solution...