search

mkko / DrawerView

A drop-in view, to be used as a drawer anywhere in your app
MIT License
373 stars 57 forks source link

update corner radius #38

Closed decanus closed 3 years ago

decanus commented 3 years ago

This should set it so the corner radius is only on top. There is a weird issue on older iphones where you see the edge of the radius at the bottom.

mkko commented 3 years ago

Thank you for the feedback on this PR. The reason it has been delayed is only because I haven't had the time to have this running and see how it works. If I remember correctly, I had issues with the corners and I had to settle for simple but ugly solution.

The issue is valid, but if it breaks the layout as wyszo mentioned, it needs to be fixed first.

decanus commented 3 years ago

Hey @mkko the issue I actually had was mainly due to how I was setting background color. We can close this PR now.

mkko commented 3 years ago

Oh. Was there something in the DrawerView API that was misleading? I'm thinking if we could improve that.

wongzigii commented 3 years ago

image

I am setting the top corners likes @wyszo , but there is extra space in iPhone Pro Max Simulator. (only in iPhone Pro Max)

mkko commented 3 years ago

Hi @wongzigii. I tried the snippet and no issues here, with Pro Max. Could you provide some simplified example where your issue occurs? It looks like a timing issue where everything is laid out before the drawer calculates its size. I might be wrong but I'd need to see your setup before I can say anything.

mkko commented 3 years ago

Sorry, mistakenly opened this issue.