Make DrawerView open - Githubissues

mkko / DrawerView

A drop-in view, to be used as a drawer anywhere in your app

MIT License

375 stars 57 forks source link

Closed KyleGoslan closed 3 years ago

KyleGoslan commented 3 years ago

Allow overrideing of DrawerView class. For more info on public vs open see: https://stackoverflow.com/a/38950955/1081325

mkko commented 3 years ago

Hi @KyleGoslan! Thank you for the contribution. I don't mind changing the modifier to open but can I ask the reason behind this?

KyleGoslan commented 3 years ago

Hi @mkko, simple answer is I wanted to subclass it.

mkko commented 3 years ago

I meant the reason behind subclassing. Is there some behavior you'd like to change?

KyleGoslan commented 3 years ago

Oh sure, sorry. No nothing that makes sense for the library, it was fairly app specific stuff.

mkko commented 3 years ago

Alright, thanks for the feedback. This needs another release, I'll try to find some time during this week.