search

mklabs / node-build-script

MIT License
322 stars 55 forks source link

Task to use Requirejs for js optimization #36

Closed EpocSquadron closed 12 years ago

EpocSquadron commented 12 years ago

This is the bare bones grunt task file and some init task changes to start the integration into node build script. This will need a little additional work with respects to integrating the task into targets for grunt build.

EpocSquadron commented 12 years ago

:-) Pull request submitted. Depending on how much time I have this week I might be able to contribute the neccesary target integration.

mklabs commented 12 years ago

Great! I'll play with it and merge into dev, most likely tomorrow.

Would you like me to hold off the pull request a little bit so that you can still attach commits for this target integration?

To me, it looks good. Maybe just a few notes in the docs on how to enable rjs optimizer and how to integrate in the overall build process would be enough. Anyway.. Thanks!

paulirish commented 12 years ago

:+1:

EpocSquadron commented 12 years ago

I most likely won't be able to make the time to finish those tasks today, so you can go ahead with merge when you're ready.

mklabs commented 12 years ago

No worries :) I'll do during the day. If you'd like to bring some tweaks, this can definitely be done with other PR as you see fit.

I'll rework the test/ directory in the meantime, this should be easier to add more tests for a given task. Probably by setting up convenience scripts to generate new ones.

mklabs commented 12 years ago

Edit: I'll do right away. This is super clean, I might add some editions later on.