search

mklabs / node-build-script

MIT License
322 stars 55 forks source link

Img task copies jpgtmp.jpg to publish/intermediate folders #49

Open jahvi opened 12 years ago

jahvi commented 12 years ago

For some reason a jpgtmp.jpg file is getting copied to my mkdirs folders, the images themselves are getting minified just fine though.

mklabs commented 12 years ago

Probably due to a clumsy implementation of the img task =/ It's related to jpegtran helper.

https://github.com/h5bp/node-build-script/blob/master/tasks/img.js#L83-114

This is used as a temporary file, as the -output option for jpegtran. Could probably clean and delete this file once the task is done though.

sylvinus commented 11 years ago

I'm also getting this file as a leftover in dist/

mklabs commented 11 years ago

Is it something still up with latest from master? #64 should have fix it.

There is now a lot of grunt plugins for image optims, including yeoman/node-jpegtran-bin and @heldr's grunt-img (which is a fork and reworked version of the img task in use here). I'm considering removing the task from the repo and use one of these tools.