jsdom has no method env

mklabs / node-build-script

MIT License

322 stars 55 forks source link

jsdom has no method env #65

Closed jeremiefourbil closed 11 years ago

jeremiefourbil commented 12 years ago

In the task dom.js it seems that the function processFile is called without his second argument jsdom in line 88.

processFile(f , function(err, window) { ... }

the result is

.../node_modules/node-build-script/tasks/dom.js:148
    jsdom.env({
          ^
TypeError: Object function (err, window) {
      if(err) return cb(err);
...
function next() {
        if(--ln) return;
        cb(null, window.document.innerHTML, window);
      }
    } has no method 'env'

mklabs commented 12 years ago

Thanks @jeremiefourbil for the feedback. You're absolutely true.

To be honest, the dom task might be killed off due to Windows support. usemin blocks (using HTML comments) and regexp parsing will kinda act as our basic parser.

mklabs commented 11 years ago

Closing. The jsdom based build will be removed from next version.