search

mklabs / tiny-lr

tiny livereload
MIT License
424 stars 90 forks source link

Update dependencies #99

Closed ntwb closed 8 years ago

ntwb commented 8 years ago

The primary 2 updates are for qs and wd • qs: ~5.1.0 -> ~6.0.1 • wd: ^0.3.12 -> ^0.4.0

The remaining are covered by existing semver though when in Rome...

elwayman02 commented 8 years ago

@ntwb it looks like the build is failing...related to the new qs version using const in strict mode. I don't think earlier versions of node support ES6 syntax, so we need to either deprecate support for those versions or keep qs on the current version. For now, can you rollback the qs upgrade and submit a separate PR where we can discuss the pros and cons of that upgrade while still being able to take advantage of these other dependency updates?

Also, sorry about taking so long to get back to you...if there are some more new versions since you submitted this PR, feel free to update them as well. I'll merge once we have a passing build.

andersevenrud commented 8 years ago

They actually refactored the const in https://github.com/ljharb/qs/commit/224c8af8fc8abf48fd9ded33a38997a1d942c1c1

So this is probably "safe" now

ntwb commented 8 years ago

Apologies it took me a while to get back to this, refreshed the pull request update all the dependancies except qs

ntwb commented 8 years ago

Added a PR for qs v6.x https://github.com/mklabs/tiny-lr/pull/101

elwayman02 commented 8 years ago

@ntwb can you rebase this really quick? Build looks good, I'll merge. Thanks!

ntwb commented 8 years ago

Rebase went horribly wrong, fresh pull request in #102