search

mklabs / vim-issues

issues.vim: A plugin to quickly navigate through issues of a GitHub repository
9 stars 2 forks source link

Problem working with private repositories #2

Open thefron opened 12 years ago

thefron commented 12 years ago

Hi. I tried using the plugin, but ran into weird exception.

Error detected while processing function 153:
line    3:
E714: List required
line   31:
E15: Invalid expression:
E15: Invalid expression:

I realised it's because the repository was a private one. Then I tried with public repository and it worked well. Is there a workaround with private repository like setting api tokens or something like that? Thanks.

mklabs commented 12 years ago

Hey @thefron

I'm afraid there are no easy fix for that. I need to make some tests on some private repo on my side to get a taste of how this might be implemented. I didn't played yet with Github API and how it now works with authentication.

The implementation is a bit naive (and most of the trickiest code is not even mine, borrowed from Tim Pope's amazing plugins, I think it was vim-rhubarb).

I'll let the issue open as I consider it a valid feature request, it just might take some time to be actually implemented, as I don't have an immediate need for it =/

mklabs commented 11 years ago

https://github.com/mattn/webapi-vim is really really nice

It has support for pretty much anything, we may be able to get this to work with this webapi.

weatheredwatcher commented 11 years ago

@mklabs I must say that being able to access a private repo's issues is VERY important to me =). I would be glad to take a stab at it. I will clone your plugin and see what I can do. I've never made a vim plugin before, but as it's quickly becoming my preferred editor =) I might as well give it the old college try!! If you have any progress/failure that you could share with me, it would be appreciated!!

hellhound commented 11 years ago

Is there anything being done regarding this issue?

mklabs commented 11 years ago

Sorry guys, nope no progress so far on my side.

5 is related, anytime we'd be able to authenticate the user to the Github API, this can be done.

Not so related, I'd like to introduce the notion of adapters and make it work with Gitlab which has a very similar API to Github's.