search

mklabs / vim-issues

issues.vim: A plugin to quickly navigate through issues of a GitHub repository
9 stars 2 forks source link

Use fugitive to show GDiff of pull requests issues? #4

Open tshirtman opened 11 years ago

tshirtman commented 11 years ago

No idea if it's easy or not, didn't look code of either plugins yet, but that would be handy to add the repos of a PR author to remotes, and show the diff of the branch using fugitive facilities.

Thanks for the work already :)

mklabs commented 11 years ago

Woow, that sounds really ambitious :)

I have no idea whether it's feasible or not, but it sure sounds interesting. Are you familiar with fugitive's internal ? I know I used a very small part of its API to get back the repository URL.

That being said, it sounds tricky. I guess fugitive is able to generate diff because the local git repo has everything it needs, here we'd need to fetch author's repo, create a local branch etc.

tshirtman commented 11 years ago

I found an alternate solution since, configured git so pulling bring me local references to pullrequests, so it makes easier to review them locally, through vim or just command line git.

https://gist.github.com/piscisaureus/3342247