Better to use shlex.split() instead of just plain str split() when parsing unix-style (posix-style) parameters (lines 234, 237). Plain split() will not correctly parse parameter values with spaces in them (e.g. echo "Hello world!").
If odbc_config is not available at line 205, then there would be no stdout and the unpacking at line 206 would fail with an obscure error (as described here).
Best not use dir as a variable at line 222 because it's a built-in function. Not an actual problem here because dir is in its own namespace within the list comprehension but still.
Bump the pyodbc package version in setup.py. Version 4.0.35 has been-and-gone now so we should be concentrating on version 4.0.36 (or perhaps 5.0.0).
General linting. This was largely done by Kleehammer in this commit but somehow it got reverted.
Some tidy-up work on
setup.py:shlex.split()instead of just plain strsplit()when parsing unix-style (posix-style) parameters (lines 234, 237). Plainsplit()will not correctly parse parameter values with spaces in them (e.g.echo "Hello world!").odbc_configis not available at line 205, then there would be no stdout and the unpacking at line 206 would fail with an obscure error (as described here).diras a variable at line 222 because it's a built-in function. Not an actual problem here becausediris in its own namespace within the list comprehension but still.setup.py. Version 4.0.35 has been-and-gone now so we should be concentrating on version 4.0.36 (or perhaps 5.0.0).