search

mkleehammer / pyodbc

Python ODBC bridge
https://github.com/mkleehammer/pyodbc/wiki
MIT No Attribution
2.95k stars 563 forks source link

Don't call setup.py directly in AppVeyor #1255

Closed keitherskine closed 1 year ago

keitherskine commented 1 year ago

A small change, but we are being discouraged from calling setup.py directly. Hence, this PR.

Note, the setup.py build command in appveyor/build_script.cmd wasn't actually needed so I've removed that.

Here's the deprecation warning in the AppVeyor output log: C:\Python311-x64\Lib\site-packages\setuptools\_distutils\cmd.py:66: SetuptoolsDeprecationWarning: setup.py install is deprecated.

mkleehammer commented 1 year ago

I saw that when I was making some fixes, but didn't take time to figure out what the right thing to do was. Looks great. Thanks.

mkleehammer commented 1 year ago

@keitherskine I noticed the Appveyor badge is gone from the front page. Any idea why? I'm guessing it was something I did in an earlier commit, but am hoping you see this.

keitherskine commented 1 year ago

Hi @mkleehammer, Yes, the AppVeyor badge was removed in this commit: https://github.com/mkleehammer/pyodbc/commit/c0961ad025f3b1375fbb206caacfdbb6eec78030

I assumed that was deliberate, but perhaps it wasn't.