search

mkleehammer / pyodbc

Python ODBC bridge
https://github.com/mkleehammer/pyodbc/wiki
MIT No Attribution
2.88k stars 561 forks source link

Can't build release artifacts due to cibuildwheel issue #1324

Closed mkleehammer closed 4 months ago

mkleehammer commented 4 months ago

Cannot build wheels on Windows due to this error:

https://github.com/pypa/cibuildwheel/issues/1748

https://github.com/pypa/cibuildwheel/issues/1740

Unfortunately, it says it is fixed in v2.16.5, but that is the version we are using.

mkleehammer commented 4 months ago

@keitherskine Have you run into this? Any ideas?

mkleehammer commented 4 months ago

The #1740 comment indicates it is sporadic for them. Maybe GH is running different runner versions?

mkleehammer commented 4 months ago

Now I'm getting something else: Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/upload-artifact@v3. For more information see:

It appears GH is not being consistent.

This is a warning that I believe is coming from the setup-qemu action, which uses node. The action has already been updated and we're using the latest version. It really seems like GH might be using old versions of actions? That would be such a huge bug I really doubt it.

keitherskine commented 4 months ago

I haven't seen this. To test, I have manually kicked off the artifacts build for tag 5.1.0 (on mkleehammer/pyodbc). Let's see if it completes successfully. On my pyodbc fork, I didn't see an error after I updated the versions of the Github Action utilities.

keitherskine commented 4 months ago

Build run: https://github.com/mkleehammer/pyodbc/actions/runs/7787826214 Takes about 10-15 minutes.

mkleehammer commented 4 months ago

Your build is already past the error I'm seeing: https://github.com/mkleehammer/pyodbc/actions/runs/7769781696/job/21236111461

keitherskine commented 4 months ago

That build has completed and the zip files of wheels can be downloaded.

The previous build failed but that was based on commit bc5b7c6 which is not tag 5.1.0 (commit f075e33). Is that the issue?

keitherskine commented 4 months ago

Meanwhile, the Appveyor build tests for tag 5.1.0 has completed: https://ci.appveyor.com/project/mkleehammer/pyodbc/builds/49115239

mkleehammer commented 4 months ago

I've uploaded the binaries from your build. I'm going to close this. If the new GH workflow is having issues, I'm sure they'll be worked out before we need them again.

keitherskine commented 4 months ago

Great stuff! pyodbc appears to work on my M1 now "clean":

(pyodbc) /Users/keith/git/pyodbc $ python -m pip install pyodbc
Collecting pyodbc
  Downloading pyodbc-5.1.0-cp311-cp311-macosx_11_0_arm64.whl.metadata (2.7 kB)
Downloading pyodbc-5.1.0-cp311-cp311-macosx_11_0_arm64.whl (71 kB)
   ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 71.6/71.6 kB 3.3 MB/s eta 0:00:00
Installing collected packages: pyodbc
Successfully installed pyodbc-5.1.0
(pyodbc) Users/keith/git/pyodbc $ python -c "import pyodbc; print(pyodbc.version)"
5.1.0
(pyodbc) /Users/keith/git/pyodbc $
keitherskine commented 4 months ago

By the way, @mkleehammer , I have updated the Wiki release notes which were rather out-of-date. They should be accurate now.