mklement0 / fileicon

macOS CLI for managing custom icons for files and folders
440 stars 20 forks source link

Allow test or get when target is readable but not writable #5

Closed zmwangx closed 8 years ago

zmwangx commented 8 years ago

Test or get should not need write permissions. On the other hand, I don't see a subcommand named "extract". Might be an outdated name.

I also removed trailing whitespace along the way.

mklement0 commented 8 years ago

Thanks again - I incorporated some of you changes in to v0.1.7, which I've just published to the npm registry.

I didn't use your PR directly, because the trailing whitespace in the man source was significant - the two trailing spaces specify an intentional line break.

However, I've added you to the package.json file as a contributor.

zmwangx commented 8 years ago

I didn't use your PR directly, because the trailing whitespace in the man source was significant - the two trailing spaces specify an intentional line break.

Sorry for the blanket trimming, I didn't pay attention to that part.

mklement0 commented 8 years ago

No worries - I appreciate your efforts - good stuff.

zmwangx commented 8 years ago

By the way, may I ask you why you put hard line breaks in the man source? You can just let groff soft-wrap it for you, which is the case for most if not all manpages I've seen. Hard line breaks are also not friendly to terminals < 80 columns.

mklement0 commented 8 years ago

Honestly, I just assumed everyone's terminal has at least 80 columns.

The hard line breaks are for cases where man is not available, and the source must be rendered as-is, such as when installing an npm package on Windows.

Where would you still come across terminals with less than 80 columns (I'm asking innocently)?

zmwangx commented 8 years ago

Where would you still come across terminals with less than 80 columns

The most common place is tmux with multiple panes. iTerm2 split panes to the same effect.

mklement0 commented 8 years ago

Got it. I personally never use these.

Given that I do want the plain-text rendering to work as it does now, I'm not sure there's a good solution.

zmwangx commented 8 years ago

Not a big deal.