Throw Incompatible OS Error Only on Use Rather than On Install

mklement0 / ttab

macOS and Linux CLI for opening a new terminal tab/window, optionally with a command to execute and/or display settings

285 stars 15 forks source link

Throw Incompatible OS Error Only on Use Rather than On Install #14

Closed philippefutureboy closed 7 years ago

philippefutureboy commented 7 years ago

Greetings!

I use ttab for development purposes on my macOS machine. I've noticed that when pushing my node js build for production on a node:carbon (linux) docker image, ttab causes the build to fail because [the] platform "linux" is incompatible with this module. Would it be possible to throw this error only when used rather than when installed ( or to support Linux #5 )?

Cheers ✨

mklement0 commented 7 years ago

If you've correctly declared ttab as a development-only dependency (key devDependencies) in your package.json file, then setting NODE_ENV to production or installing with npm install --only=production may help - see https://stackoverflow.com/a/9276112/45375

mklement0 commented 7 years ago

I'll close this for now, but we can revisit if my suggestion didn't help.

philippefutureboy commented 6 years ago

Confirmed to work with yarn install --production! Thanks for the tip :)