Added support for gnome-terminal (Ubuntu).

mklement0 commented 4 years ago

Thank you very much - this looks very promising.

There are few things we need to address before this can be merged:

We need to get clarity on what features aren't / cannot be supported in Gnome Terminal and make sure that an error is reported when their use is attempted.
- From what I can tell, the following don't work:
  - -s <settings> - it sounds like it should be possible to implement this via --window-with-profile / --tab-with-profile
  - -g for not activating Gnome Terminal (keeping the calling application, if different from Gnome Terminal, active); additionaly -G in combination with -w for not activating a new window - do you see any way of doing this?
In the embedded Markdown document fro the help, the trailing two spaces at the end of many lines must be preserved, so that the HTML rendering works as intended too.
Ideally, we'd have tests, though without AppleScript's UI automation capabilities that may be hard to do.

mklement0 commented 4 years ago

By the way: If you want to continue to work on this, that's great, but it's also an option for me to take over - either way I will give you credit for the contribution.

Let me know what you prefer.

ksvirsky commented 4 years ago

-s <settings> - it sounds like it should be possible to implement this via --window-with-profile / --tab-with-profile

Added support for specifying profile.

ksvirsky commented 4 years ago

By the way: If you want to continue to work on this, that's great, but it's also an option for me to take over - either way I will give you credit for the contribution.

Let me know what you prefer.

I've applied suggested changes. I'm not familiar very much with bash so if you think something can be improved go ahead. I just would like to add basic support for gnome-terminal. Thank you!

ksvirsky commented 4 years ago

In the embedded Markdown document fro the help, the trailing two spaces at the end of many lines must be preserved, so that the HTML rendering works as intended too.

Returned back trailings.

mklement0 commented 4 years ago

Did you mean to close this?

I will definitely take a look soon, just got a little side-tracked.

mklement0 / ttab

Added support for gnome-terminal (Ubuntu). #26