Closed Macleykun closed 2 years ago
I don't think i'm good enough with python to get the 4th todo working, so i'll leave that as is in case you think it's handy for users to have (by default i gave 8:30 up to 23:00 as that's what i prefer).
I do need to know if you want to use Dockerhub or GitHub to host the images @mklements . Otherwise i can't make the CI/CD for ya :).
Thinking about it, maybe a CI/CD would be overkill, because it won't receive that many updates i assume. So i'll just check that one off aswell :)
Here are the docs :) https://docs.github.com/en/packages/learn-github-packages/connecting-a-repository-to-a-package
https://github.com/brblacky/lavamusic/blob/main/.github/workflows/build-docker.yml we could copy this aswell :P
docker exec -t OLED_Stats i2cdetect -y 1 needed to check if it's connected right :)
heyo!
so b/c i had to reformat my pi (Again) for a weird but i have with the pixel-server github project and my wrgb adafruit ring. I had the oppurtunity to test it out and it's all working :).
Admittly, i did apt upgrade but i don't think this really did anything as the updates i got weren't related to this project.
I can fully say that the current CI/CD + docs + dockerfile + python script will work for everyone :)
Feel free to make a decision wheter to go dockerhub or github registery (i haven't tested the latter, but given these docs: https://github.com/docker/build-push-action/blob/master/docs/advanced/push-multi-registries.md https://github.com/marketplace/actions/build-and-push-docker-images) I'm confident it's set correctly :)
I will remove that after you've merged and got yours up.
sorry for caps, but i've had this happen before and it's a pain to see and wait how the horror keeps going :P
Heya :) have ya been able to have a look on this PR.? Ya have any questions maybe?
Thanks for making a new repo! I think this is indeed more user friendly!
So things that are still left before we can release this officially:
Would you want to host the images on Dockerhub or Github btw? AFAIK i don't think there's alot of difference personally.