search

mklimek / frame-video-view

Less issues with VideoView
Other
63 stars 19 forks source link

Fixes Bug Where Calling FrameVideoView.setup() with Drawable Does Not Play Video #18

Closed SharpMobileCode closed 6 years ago

SharpMobileCode commented 6 years ago

This PR fixes a bug in where calling

frameVideoView.setup(videoUri, ContextCompat.getDrawable(this, R.drawable.my_place_holder_drawable))

does not play the video. The reason the video was not being played was because impl.init() was not being called in the setup method that accepts a drawable for the place holder view.

SharpMobileCode commented 6 years ago

This will resolve #19