search

mkliszczun / route-organiser

0 stars 0 forks source link

Non-English names of methods #1

Open devcube-pl opened 4 years ago

devcube-pl commented 4 years ago

There are some non-English methods in the code. One has to use only English names.

https://github.com/mkliszczun/coding-for-fun/blob/b602088ac4aede48d9c9212348cd6f02653df63e/src/main/java/controllers/AddSteelWindow.java#L65

devcube-pl commented 4 years ago

Class names should be in English: https://github.com/mkliszczun/coding-for-fun/blob/master/src/main/java/entities/Pret.java

mkliszczun commented 4 years ago

Hmm strange, i've changed that 2 days ago, but looks like commit didn't work

devcube-pl commented 4 years ago

Have you pushed your changes into the repository?

devcube-pl commented 4 years ago

i've changed that 2 days ago

without "have" :)

mkliszczun commented 4 years ago

yeah that's right