search

mkloczko / derive-storable-plugin

MIT License
11 stars 4 forks source link

Mark plugin as pure #4

Closed expipiplus1 closed 3 years ago

expipiplus1 commented 3 years ago

To avoid forcing unnecessary recompiles

I haven't actually read the source in enough detail to know if this plugin is pure, but I'd be astonished if it isn't!

mkloczko commented 3 years ago

Thanks! The only thing that could be added is #ifdef to support older GHC versions.

expipiplus1 commented 3 years ago

Thanks!

On Tue, Dec 1, 2020, 3:18 AM Mateusz Kłoczko notifications@github.com wrote:

Merged #4 https://github.com/mkloczko/derive-storable-plugin/pull/4 into 8.10.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mkloczko/derive-storable-plugin/pull/4#event-4053553715, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGRJXFNFYMIGMAQ2WLADDDSSPVYVANCNFSM4UHG7MCA .

expipiplus1 commented 3 years ago

Could I trouble you to make a release with this change please?

mkloczko commented 3 years ago

Sure, done! 0.2.3.2 had a bug in it, so it's 0.2.3.3

expipiplus1 commented 3 years ago

Thanks!