Add support for iOS - Githubissues

mkloubert commented 8 years ago

Module should also be able to run in iOS.

sulhome commented 7 years ago

any updates on this one? thank you

mkloubert commented 7 years ago

Yesterday I startet the version 3 branch.

One new feature will be the iOS support.

Currently it is alpha and there is TypeScript support only as new "feature".

sulhome commented 7 years ago

@mkloubert thank you for your effort

buzzspaceltd commented 7 years ago

@mkloubert Thank you for the effort. Is version 3 ready now?

EddyVerbruggen commented 7 years ago

Hi @mkloubert in case you got stuck with iOS please let me know, I'd be happy to help you!

mkloubert commented 7 years ago

@EddyVerbruggen

This would be great!

mkloubert commented 7 years ago

@EddyVerbruggen

I have added you as collaborator of my repository here at GitHub and at npm ... that should make it easier for you.

Would be great if you do the iOS part, because I currently have no idea how to use the PayPal library in iOS.

EddyVerbruggen commented 7 years ago

Cool, give me some time to figure it all out :)

Do you have a specific branch you want to use for development? And is there anything already there?

And of course I'll look at the Android version so the client API's are similar.

mkloubert commented 7 years ago

@EddyVerbruggen

Take all the time you need :-)

I have prepared a v3 branch where we should submit all commits until a stable release.

This has currently the same version as the master with some updates for the demo and support for TypeScript.

I see that there is currently no support for TypeScript, so I think that this is the part I should do. I will do this in the next hours.

EddyVerbruggen commented 7 years ago

@mkloubert Thanks!

Just to be sure, are you going to convert the current plugin to TS, or are you "only" adding a TS definition file to describe the API?

Perhaps I should create the iOS version of the plugin in TS anyway, there should be no problem making it coexist with an Android JS-version.

mkloubert commented 7 years ago

@EddyVerbruggen

My idea is to create an index.ts file, that wraps the platform specific functions, which are implemented in separate modules, like Device.android.js or Device.ios.js.

So I do not need the huge definition file for Android, when I am coding.

Of cource, you can submit the TypeScript version directly, if this is easier for you.

EddyVerbruggen commented 7 years ago

Gotcha!

mkloubert commented 7 years ago

@EddyVerbruggen

I finished implementation of index.ts and index.d.ts files.

I moved the Android code to Device.android.js module and also did a small update of the README.md.

The next thing I will do the next days, is to check if the Android code and the documentation needs to be improved.

EddyVerbruggen commented 7 years ago

@mkloubert I've been dipping my toe in the iOS part of this plugin using the iOS SDK but for some reason {N} doesn't want to generate metadata from their PayPal-iOS-SDK pod. Never happened to me before really.

While investigating the cause I found that the GitHub repo actually recommends developers to use BrainTree.

BrainTree seems to be the way forward when integrating PayPal and also offers other payment methods. So it seems to me it would be better to use the BrainTree SDK instead of the PayPal SDK.

Also confirmed {N} is able to generate typings of the BrainTree SDK so integration should be possible, and TS assistance will be provided.

I could try making it play nice with the current interface you defined, and if it works nicely we may later migrate Android as well (if it makes sense at all).

WDYT?

mkloubert commented 7 years ago

@EddyVerbruggen

That's OK!