mkloubert / nativescript-social-login

NativeScript plugin for social (token based) log-ins.
MIT License
42 stars 44 forks source link

IOS Google Login no response #29

Open Willis0826 opened 6 years ago

Willis0826 commented 6 years ago

Dear teams,

I am a newbie in NativeScript, I follow the instruction to set up my Application. The google and facebook login works prefect in Android, It's will open the correct page to handle the login process, and once the process be done I will get the user result from callback ! However, when I jump into IOS, the google login is out of function, after I called SocialLogin.loginWithGoogle will crash the application, I tried both iPhone & simulator.

Here is my testing result :

IOS : 10.2.1、11.2 nativescript-social-login: "^3.0.5" tns-platform-declarations: "^3.3.0" tns-core-modules: "~3.1.1"

Due to there is no error message been log, I couldn't figure out where I did wrong. Any suggestion would be helpful !

jogboms commented 6 years ago

Thanks for reporting this issue. Could i suggest you try out the demo application included? It shows how this plugin can be implemented on both iOS and Android.

Willis0826 commented 6 years ago

@jogboms Thank you for suggestion, I will try the demo tomorrow, hope I can solve the problem which I faced.

Willis0826 commented 6 years ago

@jogboms I had tried the demo this morning. Unfortunately, the demo running on IOS failed to process google login, but the facebook login works perfectly.

Here is my testing result : IOS : 10.2.1、11.2 nativescript-social-login: "^3.0.5" tns-platform-declarations: "^3.3.0" tns-core-modules: "3.2.0"

The console didn't log any error message, once I clicked the "Login with Google", the application was crash.

jogboms commented 6 years ago

Okay @Willis0826. I'd check it out.

jogboms commented 6 years ago

@Willis0826 could you try installing the @next version and confirm if its working for you?

Willis0826 commented 6 years ago

@jogboms Spectacular! After I used npm install --save nativescript-social-login@next everything works perfectly!

Now, the plugin can running on my iPhone(10.2.1) without any error! Thank you for great help.

jogboms commented 6 years ago

Awesome. Thanks for your feedbacks @Willis0826

Willis0826 commented 6 years ago

Recently, Our team used this package to implement the login function in our Application. And we found a problem is : The function invokeLoginCallbackForGoogle which is in the SocialLogin.ios.js didn't pass the photo property, I am not sure if this is a bug or not.

However, we using the user.profile.imageURLWithDimension(100) to get the user photo url, and then pass it to googleSuccessCallback function.

@jogboms Here to share, hope this will help.

jogboms commented 6 years ago

Thanks, I'd look into this.

NikicaAsanin commented 6 years ago

Problem with GoogleLogin on iOS , android works perfectly. On button click I get log login with google.. and then nothing happen, no google login popup. help?

juliancesar commented 6 years ago

@NikicaAsanin, i have the same issue here.

nativescript-social-login: 4.0.0 nativescript-cli: 4.0.0 tns-android: 4.0.1