search

mkloubert / nativescript-social-login

NativeScript plugin for social (token based) log-ins.
MIT License
42 stars 44 forks source link

absolut path in demo: package.json #31

Closed nicHoch closed 6 years ago

nicHoch commented 6 years ago

should be changed to:

 "dependencies": {
    "nativescript-social-login": "file://../plugin/",
jogboms commented 6 years ago

@nicHoch Thanks for reporting this. Borrowing from the official plugin seed, the demo app should be initiated using the npm scripts within plugin directory e.g demo.android or demo.ios.

jdmcnair commented 6 years ago

@jogboms sorry I submitted duplicate issue #33, I should have looked first. However, I'm still a little confused about how to modify this line to make the demo work. Even if I change that absolute path to point to my local copy of the nativescript-social-login repository, there's no /plugin subdirectory (only /demo and /src). What change do I need to make to run the demo?

jdmcnair commented 6 years ago

OK, so it looks like I just needed to change that to point to the /src directory.

jogboms commented 6 years ago

oh @jdmcnair. Yeah you could do that, but its most preferred to run the demo from within the src folder using npm run demo.android or npm run demo.ios for the first time. This way, you don't have to bother about paths.