mkloubert / vs-deploy

Visual Studio Code extension that provides commands to deploy files of a workspace to a destination.
https://marketplace.visualstudio.com/items?itemName=mkloubert.vs-deploy
MIT License
131 stars 24 forks source link

Weird popup on window reload #126

Open rbingham opened 6 years ago

rbingham commented 6 years ago

When I reload a vscode window (command palette > Reload Window) this popup comes up and I have no idea what it is supposed to mean.

weird_popup

System info OS: ubuntu 16.04 vscode version: 1.18.1 vs-deploy version: 12.01

mkloubert commented 6 years ago

I have a similar issue. Yesterday I had 2 situations where an empty (warning) popup appeared.

Can you post an example config that shows, what features you are using?

rbingham commented 6 years ago

Here is what I am using:

 "deploy": {
        "targets": [
            {
                "type": "http",
                "name": "{target_name}",
                "description": "{target_description}",
                "url": "{target_url}",
                "method": "PUT",
                "user": "user",
                "password": "password"
            }
        ],
        "packages": [
            {
                "name": "{package_name}",
                "files": [
                    "{file1}"
                ],
                "targets":[
                    "{target_name}"
                ],
                "deployOnSave": true,
                "deployOnChange": true
            }
        ],
        "showPopupOnSuccess": false
    }

I would like to note that the popup was occurring even when I didn't have anything configured.

mkloubert commented 6 years ago

I found out that this has something to do with the autoSelectWorkspace setting in onDidChangeActiveTextEditor().

Please try to update to currently version 12.0.2 and try to reproduce the issue and tell me the error message, if some is displayed.

What version of VSCode do you use? Do you use the insider edition?

Btw.: Do you make use of the new multi root workspace feature?

rbingham commented 6 years ago

After updating to 12.02, this is the error that I receive: [vs-deploy] Could not auto-select workspace: 'TypeError: Cannot read property 'autoSelectWorkspace' of undefined

I'm just using the regular version of VSCode.

I do see that the error is only happening when I am using the multi root workspace feature.