search

mkloubert / vs-deploy

Visual Studio Code extension that provides commands to deploy files of a workspace to a destination.
https://marketplace.visualstudio.com/items?itemName=mkloubert.vs-deploy
MIT License
132 stars 23 forks source link

Public S3 access #134

Open ftijtaddeo opened 6 years ago

ftijtaddeo commented 6 years ago

When i deploy a file to S3, it sets the permissions on both the bucket and object to Public Read. I've been able to recreate this on demand.

mkloubert commented 6 years ago

You can set acl property to one of these values in your target.

ftijtaddeo commented 6 years ago

As a matter of security, the default here should be either no action or set to private. Making content public in S3 should require and active configuration by someone.

justinmetz commented 6 years ago

I couldn't agree more with the above statement. Defaulting to public could (and will) really burn a lot of people unknowingly.. This really needs to be addressed...