search

mkloubert / vs-deploy

Visual Studio Code extension that provides commands to deploy files of a workspace to a destination.
https://marketplace.visualstudio.com/items?itemName=mkloubert.vs-deploy
MIT License
131 stars 24 forks source link

Confirmation before deployment via button #141

Closed solid-pixel closed 6 years ago

solid-pixel commented 6 years ago

First off, let me tell you I love this extension a lot. Thank you very much!

I've added a button to deploy my files via SFTP, and while it's very convenient, it's also incredibly dangerous as with one single misclick you can easily overwrite your production site with no way of getting back your live files.

It would be great if you could add some sort of confirm() to the button in order to prevent accidental uploads.

Again thank you so much!

mkloubert commented 6 years ago

@solid-pixel @kairos03

I will not create new features in that extension, only important hotfixes.

BUT: I think that this is a good feature for the recoded version vscode-deploy-reloaded.

Is it possible to change your config to the new extension or is it too dangerous / hard work?

mkloubert commented 6 years ago

@solid-pixel @kairos03

I have implemented the feature in version 0.34.1 of vscode-deploy-reloaded.

demo20

solid-pixel commented 6 years ago

@mkloubert you're the man! Thank you so much. I don't mind giving the -reloaded version a try as my setup is very basic.

What's the difference between the two? I don't understand.

Thanks!

edit: just tried deploy-reloaded with "showPrompt": true and it works perfectly, thumbs up!

mkloubert commented 6 years ago

@solid-pixel

A cleaner API and a much better multi workspace support.

Most of the settings are the same, so I think the change to the new extension should be easy.

The old extension has grown very fast the last year and I cannot not refactor the extension without crashing it in other parts, so I decided to refactor it.

Issues and/or feature requests are welcome :-)

solid-pixel commented 6 years ago

@mkloubert thanks for clarifying, makes perfect sense :) I will certainly post my ideas and concerns, take care!