search

mknx / smarthome

http://mknx.github.io/smarthome/
GNU General Public License v3.0
126 stars 69 forks source link

switched from http.client to urllib for fetching external resources t… #174

Closed smaugs closed 9 years ago

smaugs commented 9 years ago

…o respect http_proxy environment variables

mknx commented 9 years ago

Hi,

I've used url lib in the beginning. But it have had a memory leak. I'm not sure about the request module. I think it build up on the urllib base module.

Have you monitored the memory consumption over several days. It has to be fix after a few days.

so long

Marcus

smaugs commented 9 years ago

Hi,

I've been running smarthome.py now for several days without noticing any problematic increase of memory consumption.

I've also fixed and rewritten the enttec-part of the DMX module - I initially submitted the patch for the enttec part - but for some reason it was not working anymore. It cleared out that there are some problems in connection with the python3 serial-port handling. I've rewritten the part - now it uses byte-arrays instead of strings for using the serial.write function.

For me its working now perfectly.