search

mkodekar / guava-libraries

Automatically exported from code.google.com/p/guava-libraries
Apache License 2.0
0 stars 0 forks source link

Guava testlib doesn't test support of equal, but not identical (==) map/set keys at all #1859

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Which is a very important case.

Original issue reported on code.google.com by leventov...@gmail.com on 30 Sep 2014 at 10:17

GoogleCodeExporter commented 9 years ago 
Oh, in the test-suite builders? I had never thought about that. We should do 
something about it.

Original comment by cpov...@google.com on 30 Sep 2014 at 11:23

GoogleCodeExporter commented 9 years ago 
The thing is everywhere in the framework we just use the given SimpleElements, 
same object for each "equivalence class" all the time. We don't try to, say, 
put a value for one key object, and get the value back querying equal, but not 
identical key.

Original comment by leventov...@gmail.com on 30 Sep 2014 at 11:56

GoogleCodeExporter commented 9 years ago 
*SampleElements

Original comment by leventov...@gmail.com on 30 Sep 2014 at 11:58

GoogleCodeExporter commented 9 years ago 
I did a little pre-work in this direction, just enough to hack in a quick test 
that there weren't any obvious ==/equals() bugs in Guava. (As it turns out, the 
tests of reserialized collections do a pretty good job of preventing us from 
introducing them.)

Pre-work CLs:
https://code.google.com/p/guava-libraries/source/detail?r=d6a9346dd6ca7170756a2a
6d939d7b55384229ac
https://code.google.com/p/guava-libraries/source/detail?r=730a5d308a4e5e3423ff3f
3eea1209072a8e6e75
https://code.google.com/p/guava-libraries/source/detail?r=9370140be0c19cb27d47c6
185fe232ef9000a6b8
https://code.google.com/p/guava-libraries/source/detail?r=86e4a8d67b1898c3a947f2
4c59c5ae720c86b975
https://code.google.com/p/guava-libraries/source/detail?r=366efb31c4b5f1a04490d7
6d2c1405de6bfe1697

Original comment by cpov...@google.com on 30 Oct 2014 at 2:54

GoogleCodeExporter commented 9 years ago 
This issue has been migrated to GitHub.

It can be found at https://github.com/google/guava/issues/<issue id>

Original comment by cgdecker@google.com on 1 Nov 2014 at 4:08

GoogleCodeExporter commented 9 years ago

Original comment by cgdecker@google.com on 1 Nov 2014 at 4:17

GoogleCodeExporter commented 9 years ago

Original comment by cgdecker@google.com on 3 Nov 2014 at 9:07