mkoistinen / cmsplugin-sections

A simple plugin for making fantastic "single-page scroller" websites
MIT License
11 stars 24 forks source link

Allow rendering menu in separate plugin #2

Closed helderco closed 2 years ago

helderco commented 9 years ago

These are some changes that I wanted to make for my project (#1), mainly to allow rendering the menu separately. I also went ahead and moved some of what I had in my overriden templates to the default templates, to have less and more semantic markup.

What can break for existing installations?

Appart from that, should work as it has.

Model changes

In my project I've overriden section-container.html to contain only this line:

{% include 'cmsplugin_sections/section-children.html' %}

That's because I want that default structure in my project's base.html, and still allow a default installation to give all that you need.

Other changes

astaaa commented 8 years ago

Django CMS has changed and now treebeard/mp_tree.py function get_descendants has no parameter include_self and without this parameter cms/utils/plungins.py function build_plugin_tree doesn't find plugin by parent_id. I changed get_descendants function in my virtualenv, but it's not the right solution.