Closed helderco closed 2 years ago
Django CMS has changed and now treebeard/mp_tree.py function get_descendants has no parameter include_self and without this parameter cms/utils/plungins.py function build_plugin_tree doesn't find plugin by parent_id. I changed get_descendants function in my virtualenv, but it's not the right solution.
These are some changes that I wanted to make for my project (#1), mainly to allow rendering the menu separately. I also went ahead and moved some of what I had in my overriden templates to the default templates, to have less and more semantic markup.
What can break for existing installations?
Appart from that, should work as it has.
Model changes
subordinate_page
inSectionContainerPluginModel
because it wasn't being used anywhere.HTML markup changes
<article>
is actually a specific kind of<section>
for a "thing" that stands on it's own (like in an RSS feed item). I think it's a more semantic choice;<main>
should be used for the page's main content, and should only be used once;<h2>
heading to section titles, if they exist;In my project I've overriden
section-container.html
to contain only this line:That's because I want that default structure in my project's
base.html
, and still allow a default installation to give all that you need.Other changes