search

mkoistinen / cmsplugin-sections

A simple plugin for making fantastic "single-page scroller" websites
MIT License
11 stars 24 forks source link

Bug DjangoCMS 3.1.xx fixed #4

Closed tuerlefl closed 4 years ago

tuerlefl commented 9 years ago

Had issues when creating a sectioncontainer object with DjangoCMS-Version 3.1.2

regards Florian

febsn commented 8 years ago

@mkoistinen is there a chance that this pull request will be merged anytime soon?

febsn commented 8 years ago

Hold on for a second, there seems to be a bug in tuerlefl's version. I just got this when I tried to add a section to an empty SectionContainer:

File "/Users/fabian/.virtualenvs/dawa/src/cmsplugin-sections/cmsplugin_sections/menu.py" in get_nodes
  21.             if child.page.id == self.instance.children.instance.id:

Exception Type: AttributeError at /en/
Exception Value: 'NoneType' object has no attribute 'children'

Edit: I decided not to use tuerlefl's version extending the django menu, but fix the issue on mkoistinen's version. I'll create a separate pull request for that.