search

mkomod / survival.svb

Variational Bayes for High-Dimensional Survival Analysis https://arxiv.org/abs/2112.10270
6 stars 2 forks source link

use M_PI instead of PI to support STRICT_R_HEADERS #1

Closed eddelbuettel closed 2 years ago

eddelbuettel commented 2 years ago

Dear Michaek, dear survival.svb team,

Rcpp has been preparing for a new release (in the bi-annual schedule) in which STRICT_R_HEADERS will be on by default -- see issue #1158 for all details. We have been at this since April (!!). The change requires prefixing a number of (potentially clashing) functions with Rf_ and it affects a number of (old) #define statements and uses of e.g. PI (which must become M_PI).

Your package has a similar issue (that had not come up in prior roughlt monthly runs as your package is so new): in src/partial.cpp you in four spots usePIbut the preferred form isM_PI`.

The PR makes the change, and allows survial.svb to build and test under the change from that upcoming Rcpp version. It would be great if you could fold the change in (really soon) as we plan to get this to CRAN next week.

Let me know if you have any questions.

Best, Dirk

mkomod commented 2 years ago

Thanks Dirk, all the best, Michael

eddelbuettel commented 2 years ago

Thanks for very quick merge! I market it down, it is good to know that about half of the 'open' packages have the fix applied and just need to update at CRAN. I think this all is good to go from my side in a few days.

eddelbuettel commented 2 years ago

Thanks for the prompt CRAN upload! Really appreciate it. 82 done now :) at https://github.com/RcppCore/Rcpp/issues/1158