Improve error handling for individual zmanim

[GoogleCodeExporter]

London doesn't return Alos72 from KosherJava API.

Original issue reported on code.google.com by liron.ko...@gmail.com on 7 Jul 2009 at 1:45

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

There are two problems here:

1) For some reason, Alos wasn't coming up, neither on ZmanimBot nor on 
KosherJava's
map page. I emailed Mr. KosherJava (whose name shouldn't appear in public 
forums such
as this) but he didn't get back to me yet. There's nothing else we can really do
about it.

2) ZmanimMessageParser.getZmanim() is coded in such a way that if one zman 
returns an
error (in this case, getZman() returns null and therefore we get a
NullPointerException) the whole thing doesn't work. We need a way to limit the 
effect
of individual errors - if only one zman is throwing an exception, everything 
else
should still work.  The truth is, more broadly, we need to make error messages 
more
specific - if we can't find a location, ZmanimBot.getLocation() should throw a
LocationError, if we can't calculate a Zman we should get a ZmanimError, and 
these
differences should be reflected back to the user.

Original comment by mkopinsky on 7 Jul 2009 at 4:18

[GoogleCodeExporter]

Regarding point #1 above:

Eliyahu Hershfeld (whose name can now appear online) wrote:

Are you referring to a few N/A entries? At the end of June this would have been 
worse
than it is today. The farther North you go, the greater the probability that a 
dip
below the horizon will not happen in the summer. In the arctic circle the sun 
never
sets in teh summer at all, but while it will set below the arctic circle, it 
will not
go far below the horizon. the closer you are to the arctic, the less the 
maximum dip
below the horizon will be. Let me know if this clarifies the situation.

Point #2 is still true, and we should fix that when we can.

Original comment by mkopinsky on 23 Jul 2009 at 7:25

• Changed state: Accepted

[GoogleCodeExporter]

Original comment by mkopinsky on 27 Jul 2009 at 8:30

• Changed title: Improve error handling for individual zmanim