mkopinsky / zxcvbn-php

Realistic PHP password strength estimate library based on Zxcvbn JS
MIT License
23 stars 9 forks source link

Ported matchers from upstream #1

Closed clamburger closed 6 years ago

clamburger commented 6 years ago

Changes in detail:

I've tried to avoid making any major refactoring or opinionated changes at this point, primarily sticking with the style of code already present.

Please feel free to let me know if you have any feedback.

mkopinsky commented 6 years ago

This is awesome - I'm really glad to have a partner in this project. Aside from just the remaining matchers and tests that I didn't get to, there are also lots of improvements in this - data providers, ReflectionClass to test protected methods, syntax consistency, and so on.