search

mkopylec / charon-spring-boot-starter

Reverse proxy implementation in form of a Spring Boot starter.
Apache License 2.0
245 stars 55 forks source link

Allow manual mappings update #10

Closed ludoo0d0a closed 8 years ago

ludoo0d0a commented 8 years ago

It would be great to have a manual entry to update mappings, not only when request failed. In a case where MappingsProvider would be updated externally (updated properties file, or DB storage)

Anyway, nice project. I hope to see more features later ;)

mkopylec commented 8 years ago

Hi, I am not sure what do mean. Could you please provide more details and/or maybe a sample code?

What do you mean by "manual"? Would you like to have a feature that allows you to update mappings using JMX?

ludoo0d0a commented 8 years ago

I'd like to update mappings without restarting app (live update). Once updated, I need a method to call this update.

But after digging into your code, it seems it is already feasible since beans are optional (well done :) I test a version where I set my own MappingsProvider and I can call 'updateMappings' on it.

mkopylec commented 8 years ago

Yes, you can call updateMappings() from your application code whenever you want. This call will update the mappings according to your MappingsProvider implementation. Let me know if this is OK for you. If so I the issue should be closed.

ludoo0d0a commented 8 years ago

Finished a first version. It works fine ! Thanks.

mkopylec commented 8 years ago

Great :)