Closed markusmoormann closed 6 years ago
Thanks for spotting the bug.
I'm strugling if we should or should not update CharonProperties
with the new mappings values.
Maybe CharonProperties
should always represent the yml file configuration and therefore not be changed after mappings update.
I've created an alternative fix for the bug: https://github.com/mkopylec/charon-spring-boot-starter/pull/37
What do you think about it?
Fixed in 2.1.1
I'm just testing around with your library and realized that it seems not to work when using a MappingProvider
This doesn't work because after retrieving the new mappings
httpClientProvider.updateHttpClients();
is called which iterates ofter the mappings in theCharonProperties
. So before updating the HttpClients theCharonProperties
need to be informed over the new settings. I've prepared a patch for this