Enhance mapping by adding custom metadata

mkopylec / charon-spring-boot-starter

Reverse proxy implementation in form of a Spring Boot starter.

Apache License 2.0

240 stars 54 forks source link

Enhance mapping by adding custom metadata #54

Closed jecuendet closed 6 years ago

jecuendet commented 6 years ago

This can be useful to add specific behaviour in corner cases, by mapping

coveralls commented 6 years ago

Coverage increased (+0.02%) to 92.066% when pulling 7422f732531e933ea2fa028d1e535f1be0149919 on shared-vd:Flexible_Mappings into f932f2493a81338825e46ac3c6af161a3c85a6f7 on mkopylec:master.

mkopylec commented 6 years ago

I don't really think it is necessary. Could you please provide some example use cases for the metadata? If there are some, maybe their configuration can be defined explicitly, not by Map.

mkopylec commented 6 years ago

Also please check https://github.com/mkopylec/charon-spring-boot-starter#contribution information. I've created the special branch for external PRs, because it is hard for me to maintain them in main branch.

jecuendet commented 6 years ago

The main idea is to be able to introduce workarounds in the Charon process The PR #53 is another idea to get this. But the workaround in #53 may not please you... The idea of PRs #53 and #54 is to discuss problem and solutions.

If #53 is not accepted, with #54 we could define metadata in the mapping config then override a Spring Bean to create the workaround outside of Charon, in the application

Exemple

` charon.mappings:

name: application that is not chunk compliant metadata: workaround-premature-end-chunk: true `

mkopylec commented 6 years ago

OK, you're right. Workarounds can't be done without additional mappings configuration. Please change the destination branch of #54 to pull-requests.

jecuendet commented 6 years ago

Done. Switched to pull-request branch

jecuendet commented 6 years ago

Would you create a 2.4.1?