search

mkopylec / charon-spring-boot-starter

Reverse proxy implementation in form of a Spring Boot starter.
Apache License 2.0
240 stars 54 forks source link

Allow ReceivedResponseInterceptor to access RequestData #57

Closed malinges closed 6 years ago

malinges commented 6 years ago

Some use-cases require ReceivedResponseInterceptor to have access to RequestData. One example is properly handling CORS preflight requests from within Charon, which requires access to the request's method and headers. This PR adds a reference to RequestData in ResponseData, allowing ReceivedResponseInterceptor to access it.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+1.5%) to 93.639% when pulling 39b73f2e89fa2b2ced390b974742e23c3ec98b8e on malinges:master into 3380307d1521493ba1269189cd5a5a83909b6b57 on mkopylec:master.

mkopylec commented 6 years ago

Thanks for the PR but there should also be some tests written for it.